Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: macOS support for scripts/genproto.sh #16883

Merged
merged 1 commit into from
Nov 8, 2023
Merged

scripts: macOS support for scripts/genproto.sh #16883

merged 1 commit into from
Nov 8, 2023

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Nov 7, 2023

This commit will allow scripts/genproto.sh to fall back to gsed if available, which is required for the script to work on macOS.

Fixes #16760

@mjlshen
scripts: macOS support for scripts/genproto.sh
27272c3 
This commit will allow scripts/genproto.sh to fall back to gsed if
available, which is required for the script to work on macOS.

Signed-off-by: Michael Shen <mishen@umich.edu>
@etsrpl
Copy link
Contributor

etsrpl commented Nov 8, 2023

It looks like it's working on my mac (truncated output below)

protodoc is finished.

The API references have NOT been automatically published on the website.

To publish the API references, copy the following files
  - Documentation/dev-guide/api_reference_v3.md
  - Documentation/dev-guide/api_concurrency_reference_v3.md
to the etcd-io/website repo under the /content/en/docs/next/dev-guide/ folder.
(https://github.com/etcd-io/website/tree/main/content/en/docs/next/dev-guide)

./genproto SUCCESS`

jmhbnz
jmhbnz approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mjlshen! 🎉

@serathius serathius merged commit 649b365 into etcd-io:main Nov 8, 2023
27 checks passed
@mjlshen mjlshen deleted the 16760 branch November 8, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
stage/merge-when-tests-green
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[release-3.5] MacOS support for scripts/genproto.sh
4 participants
@mjlshen @etsrpl @serathius @jmhbnz