Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v2 proposals code #16967

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Remove v2 proposals code #16967

merged 2 commits into from
Nov 21, 2023

Conversation

serathius
Copy link
Member

@serathius serathius commented Nov 19, 2023

Etcd v3.6 no longer supports v2 storage as so it no longer needs to make v2 proposals.
This PR removes the code required to make v2 proposals.

Part of #12913

cc @ahrtr

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius force-pushed the remove-v2-proposals branch 2 times, most recently from 8331429 to 874251a Compare November 19, 2023 21:32
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Copy link
Member Author

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahrtr ahrtr merged commit ec6147c into etcd-io:main Nov 21, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants