Reproduce #17529 in robustness tests #17680
Conversation
|
Skipping CI for Draft Pull Request. |
|
Based on #16761 as introducing compaction prevents us from depending on Watch events for their persistance. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #17680 +/- ##
==========================================
+ Coverage 68.75% 68.95% +0.20%
==========================================
Files 416 416
Lines 35128 35128
==========================================
+ Hits 24152 24223 +71
+ Misses 9569 9512 -57
+ Partials 1407 1393 -14 Continue to review full report in Codecov by Sentry.
|
serathius
force-pushed
the
issue-17529
branch
6 times, most recently
from
6d11170
to
24f0a7f
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
|
cc @fuweid @siyuanfoundation @MadhavJivrajani |
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
|
/retest |
| @@ -0,0 +1,12 @@ | |||
| diff --git a/server/etcdserver/api/v3rpc/watch.go b/server/etcdserver/api/v3rpc/watch.go | |||
|
/retest |
| sws.mu.RUnlock() | ||
|
|
||
| var serr error | ||
| + // gofail: var beforeSendWatchResponse struct{} |
There was a problem hiding this comment.
should the failpoint also be backported to 3.5 to ensure the issue is fixed for the latest 3.5 release?
There was a problem hiding this comment.
Right, there is even a issue for that #17817
|
ping @fuweid @MadhavJivrajani |
Reproduce #17529