Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] Update the compaction log when bootstrap and update compact's signature #17831

Merged
merged 1 commit into from
Apr 23, 2024
Merged

[3.4] Update the compaction log when bootstrap and update compact's signature #17831

merged 1 commit into from
Apr 23, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 21, 2024

Backport #17792

@ahrtr
Update the compaction log when bootstrap and update compact's signature
f8f1864 
Actually the compact() never return an error, so remove the second return
parameter.

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr mentioned this pull request Apr 21, 2024
Merged
@ahrtr
Copy link
Member Author

ahrtr commented Apr 23, 2024

cc @fuweid @serathius @spzala

fuweid
fuweid approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 913a080 into etcd-io:release-3.4 Apr 23, 2024
17 checks passed
@ahrtr ahrtr deleted the 3.4_update_compact_log_bootstrap_20240421 branch June 12, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrtr @serathius @fuweid