Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/storage/mvcc: should update currentRev in revMu #17862

Merged
merged 1 commit into from
Apr 24, 2024
Merged

server/storage/mvcc: should update currentRev in revMu #17862

merged 1 commit into from
Apr 24, 2024

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Apr 24, 2024

@fuweid
server/storage/mvcc: should update currentRev in revMu
94c83a9 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fuweid fuweid marked this pull request as ready for review April 24, 2024 03:32
This was referenced Apr 24, 2024
Merged
Merged
Open
ahrtr
ahrtr approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good catch, we should update the currentRev under the protection of s.revMu.

@serathius serathius merged commit dc9cfd6 into etcd-io:main Apr 24, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
backport/v3.4 backport/v3.5 ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuweid @k8s-ci-robot @serathius @ahrtr