bugfix: register of walWriteSec

[andyxning]

bugfix: #17618.

walWriteSec should be registered in prometheus.

/cc @Akiqqqqqqq

[k8s-ci-robot]

@andyxning: GitHub didn't allow me to request PR reviews from the following users: Akiqqqqqqq.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

bugfix: #17618.

walWriteSec should be registered in prometheus.

/cc @Akiqqqqqqq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Hi @andyxning. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 18.84058% with 56 lines in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (9914047) to head (5749924).
Report is 48 commits behind head on main.

❗ Current head 5749924 differs from pull request most recent head 4a555fe

Please upload reports for the commit 4a555fe to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Files	Coverage Δ
server/embed/config.go	78.95% <100.00%> (ø)
server/etcdmain/config.go	64.39% <100.00%> (+0.82%)	⬆️
server/storage/mvcc/hash.go	100.00% <100.00%> (ø)
server/storage/mvcc/kvstore.go	90.44% <100.00%> (ø)
server/storage/wal/metrics.go	100.00% <100.00%> (ø)
etcdutl/ctl.go	0.00% <0.00%> (ø)
etcdutl/etcdutl/printer_json.go	0.00% <0.00%> (ø)
pkg/expect/expect.go	79.12% <50.00%> (ø)
etcdutl/etcdutl/printer_fields.go	0.00% <0.00%> (ø)
etcdutl/etcdutl/printer_simple.go	0.00% <0.00%> (ø)
... and 3 more

... and 28 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18164      +/-   ##
==========================================
- Coverage   69.19%   68.75%   -0.44%     
==========================================
  Files         415      416       +1     
  Lines       35043    35128      +85     
==========================================
- Hits        24249    24154      -95     
- Misses       9412     9568     +156     
- Partials     1382     1406      +24     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9914047...4a555fe. Read the comment docs.

[ivanvc]

/ok-to-test

[ivanvc]

/retest

[ivanvc]

LGTM. Thanks, @andyxning. This will need a release-3.5 backport.

[jmhbnz]

LGTM - Thanks for fixing this @andyxning

[andyxning]

@ivanvc Done. #18174

[ahrtr]

Please raise a PR to update the 3.5 changelog. thx

[andyxning]

@ahrtr This is a bugfix to adding support for walWriteSec and walWriteSec was added in v3.5. There is no need to update in the changelog, imho.

[ahrtr]

@ahrtr This is a bugfix to adding support for walWriteSec and walWriteSec was added in v3.5. There is no need to update in the changelog, imho.

We are updating changelog to clarify the bugfix instead of the new feature.