Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove context from appliers #18677

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

serathius
Copy link
Member

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (620a00b) to head (59d3718).

Current head 59d3718 differs from pull request most recent head 08d54bc

Please upload reports for the commit 08d54bc to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/apply/apply.go 78.02% <100.00%> (ø)
server/etcdserver/apply/apply_auth.go 100.00% <100.00%> (ø)
server/etcdserver/apply/corrupt.go 100.00% <100.00%> (ø)
server/etcdserver/apply/uber_applier.go 86.17% <100.00%> (-0.12%) ⬇️

... and 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18677      +/-   ##
==========================================
+ Coverage   68.70%   68.84%   +0.13%     
==========================================
  Files         420      420              
  Lines       35541    35540       -1     
==========================================
+ Hits        24418    24467      +49     
+ Misses       9687     9647      -40     
+ Partials     1436     1426      -10     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620a00b...08d54bc. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member Author

/retest

@serathius serathius merged commit 7b429f9 into etcd-io:main Oct 4, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants