Remove context from mvcc public interface #18678
Conversation
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -304,72 +296,6 @@ func setup(t *testing.T, setup testSetup) (mvcc.KV, lease.Lessor) { | |||
| return s, lessor | |||
| } | |||
|
|
|||
| func TestReadonlyTxnError(t *testing.T) { | |||
There was a problem hiding this comment.
Need to double check the original motivation for the test and if we need to rewrite it. Marking the PR as draft until then.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 17 files with indirect coverage changes @@ Coverage Diff @@
## main #18678 +/- ##
==========================================
- Coverage 68.80% 68.75% -0.06%
==========================================
Files 420 420
Lines 35540 35544 +4
==========================================
- Hits 24455 24437 -18
- Misses 9666 9681 +15
- Partials 1419 1426 +7 Continue to review full report in Codecov by Sentry.
|
cc @ahrtr
#18667 (comment)