Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: binding listeners must be IP. #9638

Merged
merged 1 commit into from
May 2, 2018
Merged

Conversation

hexfusion
Copy link
Contributor

ref: #6336, #9575

@@ -391,7 +391,7 @@ infra2.example.com. 300 IN A 10.0.1.12

#### Bootstrap the etcd cluster using DNS

etcd cluster members can listen on domain names or IP address, the bootstrap process will resolve DNS A records.
etcd cluster members can advertise domain names or IP address, the bootstrap process will resolve DNS A records.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense I found that after the fact. Will update to reflect versions.

@xiang90
Copy link
Contributor

xiang90 commented Apr 26, 2018

lgtm in general.

@hexfusion
Copy link
Contributor Author

@gyuho updated, thanks.

@codecov-io
Copy link

Codecov Report

Merging #9638 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9638      +/-   ##
=========================================
- Coverage   69.33%   69.2%   -0.14%     
=========================================
  Files         373     373              
  Lines       34427   34427              
=========================================
- Hits        23870   23824      -46     
- Misses       8867    8904      +37     
- Partials     1690    1699       +9
Impacted Files Coverage Δ
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
etcdserver/api/v3rpc/lease.go 70.93% <0%> (-8.14%) ⬇️
etcdctl/ctlv3/command/lease_command.go 65.34% <0%> (-5.95%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
etcdserver/v2_server.go 80.76% <0%> (-3.85%) ⬇️
etcdserver/api/v3rpc/watch.go 70.88% <0%> (-3.45%) ⬇️
etcdserver/v3_server.go 73.92% <0%> (-3.35%) ⬇️
rafthttp/msgappv2_codec.go 69.56% <0%> (-1.74%) ⬇️
pkg/netutil/netutil.go 68.85% <0%> (-1.64%) ⬇️
lease/leasehttp/http.go 58.08% <0%> (-1.48%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94cd5e...2afd827. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @hexfusion

@gyuho gyuho merged commit 859172e into etcd-io:master May 2, 2018
guessi added a commit to guessi/docker-compose-etcd that referenced this pull request Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants