Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: more metrics for bboltdb transaction #9834

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Jun 11, 2018

@gyuho @jpbetz

We observed high latency in the commit call. Adding more metrics can help to understand which part of bbolt commit is the root cause.

Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a question in the last etcd community meeting of if we should keep the "etcd_debugging" but since we don't have a final decision on that, I think it makes sense to continue to use it.

The histograms look good to me. Thanks!

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks @xiang90 !

@gyuho
Copy link
Contributor

gyuho commented Jun 11, 2018

Added change log and missing prometheus register calls. Merging in greens.

@gyuho
Copy link
Contributor

gyuho commented Jun 11, 2018

Also replaced metrics naming to _ /cc @xiang90

panic: descriptor Desc{fqName: "etcd_debugging_disk_backend_commit.rebalance_duration_seconds", help: "The latency distributions of commit.rebalance called by bboltdb backend.", constLabels: {}, variableLabels: []} is invalid: "etcd_debugging_disk_backend_commit.rebalance_duration_seconds" is not a valid metric name

@xiang90
Copy link
Contributor Author

xiang90 commented Jun 11, 2018

@gyuho Thank you!

@gyuho gyuho merged commit 59aec1f into etcd-io:master Jun 11, 2018
@xiang90 xiang90 deleted the m_m branch June 11, 2018 21:49
@jpbetz
Copy link
Contributor

jpbetz commented Jun 11, 2018

cc @wenjiaswe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants