Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: clarify read index warnings, add metrics #9897

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jul 2, 2018

Current read index warnings are just dumping raw bytes of request ID that nobody understands.

This PR prints out corresponding request IDs to show how much follower falls behind. Also, add etcd_server_slow_read_indexes_total metrics to monitor how many read requests are out-of-sync or timed out.

Before

ignored out-of-date read index response (want [0 1 2 3 5], got [0 1 2 3 6])

After

ignored out-of-date read index response; local node read indexes queueing up and waiting to be in sync with leader (request ID want 101, got 100)

/cc @SaranBalaji90

gyuho added 2 commits July 2, 2018 12:53
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #9897 into master will decrease coverage by 0.13%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9897      +/-   ##
==========================================
- Coverage   69.22%   69.09%   -0.14%     
==========================================
  Files         386      386              
  Lines       35791    35798       +7     
==========================================
- Hits        24776    24734      -42     
- Misses       9215     9263      +48     
- Partials     1800     1801       +1
Impacted Files Coverage Δ
etcdserver/metrics.go 77.14% <100%> (+0.67%) ⬆️
etcdserver/v3_server.go 66.43% <28.57%> (-8.99%) ⬇️
etcdserver/api/v3rpc/lease.go 69.31% <0%> (-4.55%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
pkg/transport/listener.go 58.67% <0%> (-4.09%) ⬇️
etcdserver/util.go 95% <0%> (-3.75%) ⬇️
mvcc/watcher.go 96.29% <0%> (-3.71%) ⬇️
clientv3/concurrency/election.go 79.52% <0%> (-2.37%) ⬇️
raft/storage.go 87.96% <0%> (-1.86%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308f590...37000cc. Read the comment docs.

@gyuho gyuho merged commit 495eb2f into etcd-io:master Jul 3, 2018
@gyuho gyuho deleted the read-index branch July 3, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants