Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netlify previews for draft pages #325

Closed
chalin opened this issue May 26, 2021 · 2 comments
Closed

Netlify previews for draft pages #325

chalin opened this issue May 26, 2021 · 2 comments
Labels
infrastructure Categorizes issue or PR as related to site infrastructure.
Milestone
21Q3-post-reorg

Comments

@chalin
Copy link
Contributor

chalin commented May 26, 2021

It should be possible to preview draft pages on Netlify without having to force that draft pages are build for all previews. On grpc.io, for example, previews include draft pages if the PR branch name includes draft. Should we do the same thing here?

As of #324, draft pages will always appear in preview. I did this so that we can make quick enough progress in the review of the v3.5 blog entry.
@chalin chalin added the infrastructure Categorizes issue or PR as related to site infrastructure. label May 26, 2021
This was referenced May 26, 2021
Merged
Merged
@chalin chalin added this to the 21Q3-post-reorg milestone May 27, 2021
@nate-double-u
Copy link
Contributor

I think I'm OK with Drafts and Future pages getting rendered on all preview builds. How we have it set up now is simple, and straightforward. I think that having to add draft to a branch name would get overlooked when it comes time that someone needs a draft rendered in preview.

@chalin
Copy link
Contributor Author

chalin commented Jul 12, 2021

Yep, that works for me.

@chalin chalin closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Categorizes issue or PR as related to site infrastructure.
Projects
None yet
Milestone
21Q3-post-reorg
Development

No branches or pull requests
2 participants
@chalin @nate-double-u