Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content/en/blog/2021: add "Announcing etcd 3.5" #312

Merged
merged 3 commits into from
May 27, 2021
Merged

content/en/blog/2021: add "Announcing etcd 3.5" #312

merged 3 commits into from
May 27, 2021

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 25, 2021

@chalin
Copy link
Contributor

chalin commented May 26, 2021

@gyuho - could you rebase? That will allow us to see the blog post under the Netlify preview (following #325). Thanks.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
Copy link
Contributor Author

gyuho commented May 26, 2021

@chalin Done. Thanks!

@chalin chalin self-requested a review May 26, 2021 16:54
@chalin
Copy link
Contributor

chalin commented May 26, 2021

@gyuho - I submitted a commit with fixes to the links, and added an authors field

The page preview now works: https://deploy-preview-312--etcd.netlify.app/blog/2021/announcing-etcd-3.5/

/cc @nate-double-u

@gyuho
Copy link
Contributor Author

gyuho commented May 26, 2021

Preview looks good to me. Thanks!

@chalin
Copy link
Contributor

chalin commented May 26, 2021

@gyuho - I propose that we merge this PR. I'll make a pass and submit copyedits in a followup PR. How does that sound?

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to merge as a draft page. As I mentioned in the previous comment, I'll review it after from and submit followup PRs.

@xiang90
Copy link

xiang90 commented May 26, 2021

lgtm

@gyuho
Copy link
Contributor Author

gyuho commented May 26, 2021

I propose that we merge this PR. I'll make a pass and submit copyedits in a followup PR. How does that sound?

Sounds good. Let's merge then. Thanks!

@chalin chalin merged commit 7de6311 into etcd-io:main May 27, 2021
@chalin
Copy link
Contributor

chalin commented May 27, 2021

@hexfusion @xiang90 et all: for followup edits, see #331

Copy link
Contributor

@tangcong tangcong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same behavior as 3.3? @gyuho

transactions. etcd 3.5 made multiple improvements to further increase the
transaction concurrency: (1) If a transaction includes a PUT(update) operation,
the transaction instead shares the transaction buffer between reads and writes
(same behavior as 3.4) in order to avoid copying buffers. This transaction mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same behavior as 3.3?

Google)](https://github.com/etcd-io/etcd/pull/11613), (5) client cancelling
watch does not signal server creating leaky watchers, and the fix was to
explicitly send a cancel request to the server -- see [jackkleeman@'s fix (from
Apple)](https://github.com/etcd-io/etcd/pull/11613).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have submitted pr #384 to fix the above two typo issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants