Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document --auth-token flag #706

Closed
twz123 opened this issue Jul 5, 2023 · 3 comments
Closed

Document --auth-token flag #706

twz123 opened this issue Jul 5, 2023 · 3 comments
Assignees
@edragone
Labels
contribfest Issues for Contribfest workshop happening during KubeCon enhancement New feature or request help wanted Extra attention is needed

Comments

@twz123
Copy link

twz123 commented Jul 5, 2023 •
edited
Loading

etcd-io/etcd#16174 adds support for for the EdDSA JWT signing algorithm. While reviewing that PR, it turned out that the whole flag needs to be documented: etcd-io/etcd#16174 (comment).
@twz123 twz123 mentioned this issue Jul 5, 2023
Merged
@jmhbnz jmhbnz added enhancement New feature or request help wanted Extra attention is needed labels Jul 5, 2023
@twz123 twz123 changed the title Document new JWT signing algorithm: EdDSA Document --auth-token flag Jul 5, 2023
@jmhbnz jmhbnz mentioned this issue Oct 25, 2023
Closed
2 tasks
@jmhbnz jmhbnz added the contribfest Issues for Contribfest workshop happening during KubeCon label Oct 25, 2023
@edragone
Copy link
Contributor

edragone commented Nov 7, 2023

I'm interested in working on this

@nate-double-u
Copy link
Contributor

Thanks @edragone, assigned!

edragone added a commit to edragone/website that referenced this issue Nov 7, 2023
@edragone
docs: documented auth-token supported signing methods.
2be8718 
Resolves issue etcd-io#706 by moving the documented signing methods from v3.4/op-guide/configuration.md to
v3.5/op-guide/configuration.md

Signed-off-by: Eddie Dragone <edragone07@gmail.com>
@edragone edragone mentioned this issue Nov 7, 2023
Merged
edragone added a commit to edragone/website that referenced this issue Nov 7, 2023
@edragone
docs: documented auth-token supported signing methods.
cc3504d 
Resolves issue etcd-io#706 by moving the documented signing methods from v3.4/op-guide/configuration.md to
v3.5/op-guide/configuration.md

Signed-off-by: edragone <edragone07@gmail.com>
edragone added a commit to edragone/website that referenced this issue Nov 7, 2023
@edragone
docs: documented auth-token supported signing methods
941cfe1 
    Resolves issue etcd-io#706 by moving the documented signing methods from v3.4/op-guide/configuration.md to
    v3.6/op-guide/configuration.md

Signed-off-by: edragone <edragone07@gmail.com>
@jmhbnz
Copy link
Member

jmhbnz commented Nov 16, 2023

Closing, completed in #746.

@jmhbnz jmhbnz closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edragone edragone

Labels
contribfest Issues for Contribfest workshop happening during KubeCon enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@twz123 @nate-double-u @edragone @jmhbnz