Expose more protobuf structs to make transactions testable and mockable #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the following actions: - Convert the `txn` parameter passed to `etcd_client::KvClient::txn` into a `PbTxnRequest` and check that the right transaction conditions, success, and failure operations are present. - Construct (and return) nested transaction responses during mocking.
|
I could use this as well. I was thinking we could also just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David,
I already had the feeling that the last PR related to mocking (#23) did not expose everything related to it. It turns out that a few more changes are required in order to test / mock transactions, which are of course crucial for more complex services leveraging
etcd_client.This PR enables the following actions by exposing just a few more protobuf structs:
txnparameter passed toetcd_client::KvClient::txninto aPbTxnRequestand check that the right transaction conditions, success, and failure operations are used.What do you think? Any feedback is highly appreciated. Thanks in advance!