Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split apart large integration tests logs files on Github Actions #485

Closed
snario opened this issue Apr 18, 2021 · 3 comments
Closed

Split apart large integration tests logs files on Github Actions #485

snario opened this issue Apr 18, 2021 · 3 comments
Assignees

Comments

@snario
Copy link
Contributor

snario commented Apr 18, 2021

In the optimism-integration repo, we added code to do some parsing on the output of docker-compose up such that the logs from running many services were more easily parseable and accessible from Github Actions. I think we should revisit this work and port it for use in this repository.

@snario snario added the A-ci label Apr 18, 2021
@gakonst
Copy link
Contributor

gakonst commented Apr 19, 2021

Why would we want to view logs on CI? You can view the logs locally by running docker-compose logs --follow <name of service>

@snario
Copy link
Contributor Author

snario commented Apr 19, 2021

Why would we want to view logs on CI? You can view the logs locally by running docker-compose logs --follow <name of service>

I find that it makes it much easier to demonstrate the circumstances that lead to failing test cases in a way that can be linked to over the internet.

This means I can parse through the logs without having to do any local configuration and develop an intuition for a bug.

It also removes all possibility of some local development quirk leading to a false positive bug report or reproduction steps.

Also, when trying to demonstrate a successful example of something working when someone is unsure about it, I can link to an exact snippet of the logs demonstrating some functionality.

In general I'd say viewing CI logs improves a developer team's productivity.

@snario
Copy link
Contributor Author

snario commented Jun 17, 2021

Fixed by #1020 and #1098

bap2pecs added a commit to babylonlabs-io/optimism that referenced this issue Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants