Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: pin to alpine 3.13 for l2geth #1199

Merged
merged 1 commit into from
Jul 1, 2021
Merged

docker: pin to alpine 3.13 for l2geth #1199

merged 1 commit into from
Jul 1, 2021

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jul 1, 2021

Description
A bug has appeared when older versions of Docker are used to build
alpine based images in alpine version 3.14. To prevent this problem
from happening to the users, this PR pins the version to 3.13.

The observed problem is that make cannot run any command and
the error message states Operation not permitted. Removing
make was one way to solve the problem but that would increase
the diff from upstream geth.

See these links for details:
alpinelinux/docker-alpine#182
https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0

A bug has appeared when older versions of Docker are used to build
alpine based images in alpine version 3.14. To prevent this problem
from happening to the users, this PR pins the version to 3.13.

The observed problem is that `make` cannot run any command and
the error message states `Operation not permitted.` Removing
`make` was one way to solve the problem but that would increase
the diff from upstream geth.

See these links for details:
alpinelinux/docker-alpine#182
https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2021

⚠️ No Changeset found

Latest commit: c3868f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

Codecov Report

Merging #1199 (c3868f4) into develop (99e3adb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1199   +/-   ##
========================================
  Coverage    86.05%   86.05%           
========================================
  Files           49       49           
  Lines         1936     1936           
  Branches       307      307           
========================================
  Hits          1666     1666           
  Misses         270      270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e3adb...c3868f4. Read the comment docs.

Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you know which versions of Docker are OK and which aren't?

@tynes
Copy link
Contributor Author

tynes commented Jul 1, 2021

LGTM. Do you know which versions of Docker are OK and which aren't?

This is in github issue link above the easiest way to fix this is to upgrade Docker to version 20.10.0 or later.

@tynes tynes merged commit e615144 into develop Jul 1, 2021
@tynes tynes deleted the fix/alpine-image branch July 1, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ops Area: ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants