-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
l2geth: allow 0 gasprice txs for OVM_GasPriceOracle.owner
#1241
Conversation
🦋 Changeset detectedLatest commit: 0404c96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
if err != nil { | ||
t.Fatal(err) | ||
} | ||
signer := types.NewEIP155Signer(big.NewInt(420)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple small things but overall this looks great!
fdae194
to
bfc18cb
Compare
This PR allows the owner of the `OVM_GasPriceOracle` to send transactions with 0 gas price when the enforce fees config option is turned on. The L2 gas price is currently updated by sending transactions to the chain to a special contract. In the future it should be updated as a side effect of transaction execution. Having the gas price on chain is important so that it can be replicated accross the network to ensure that users can send transactions with a high enough fee. Having the `OVM_GasPriceOracle.owner` key not need to maintain ETH on L2 is an operational simplification as well prevents a terrible scenario where a bug causes the L2 gas price to go so high that it is impossible for the owner to update it.
Description
This PR allows the owner of the
OVM_GasPriceOracle
to sendtransactions with 0 gas price when the enforce fees config option
is turned on.
The L2 gas price is currently updated by sending transactions to the
chain to a special contract. In the future it should be updated as a
side effect of transaction execution. Having the gas price on chain is
important so that it can be replicated accross the network to ensure
that users can send transactions with a high enough fee.
Having the
OVM_GasPriceOracle.owner
key not need to maintainETH on L2 is an operational simplification as well prevents a
terrible scenario where a bug causes the L2 gas price to go so high
that it is impossible for the owner to update it.
Metadata