ci: handle gas-oracle latest image, skip builder #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the `ops/scripts/ci-versions.js` file to skip building the builder image for when there are changes to the `gas-oracle`. The `builder` contains all of the JS code required for the various typescript based services. This PR also publishes `ethereumoptimism/gas-oracle:latest`. It is faster to `docker pull` than `docker build`. This will speed up the workflow for developers building locally against the `docker compose` setup as well as the CI if it is refactored to pull the `latest` images for the unchanged images instead of building them from scratch.
|
snario
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
ops/scripts/ci-versions.jsfileto skip building the builder image for when there
are changes to the
gas-oracle. Thebuildercontainsall of the JS code required for the various typescript
based services.
This PR also publishes
ethereumoptimism/gas-oracle:latest.It is faster to
docker pullthandocker build.This will speed up the workflow for developers building locally
against the
docker composesetup as well as the CI if itis refactored to pull the
latestimages for the unchanged imagesinstead of building them from scratch.