Merge 23a3d09 into fede8c5

ethereum · Jan 3, 2024 · 5e7687a · 5e7687a
2 parents fede8c5 + 23a3d09
commit 5e7687a
Showing 1 changed file with 48 additions and 11 deletions.
diff --git a/EIPS/eip-145.md b/EIPS/eip-145.md
@@ -1,17 +1,14 @@
 ---
 eip: 145
 title: Bitwise shifting instructions in EVM
+description: To Provide native bitwise shifting with cost on par with other arithmetic operations.
 author: Alex Beregszaszi (@axic), Paweł Bylica (@chfast)
+status: Final
 type: Standards Track
 category: Core
-status: Final
 created: 2017-02-13
 ---
 
-## Simple Summary
-
-To provide native bitwise shifting with cost on par with other arithmetic operations.
-
 ## Abstract
 
 Native bitwise shifting instructions are introduced, which are more efficient processing wise on the host and are cheaper to use by a contract.
@@ -33,6 +30,7 @@ The `SHL` instruction (shift left) pops 2 values from the stack, first `arg1` an
 ```
 
 Notes:
+
 - The value (`arg2`) is interpreted as an unsigned number.
 - The shift amount (`arg1`) is interpreted as an unsigned number.
 - If the shift amount (`arg1`) is greater or equal 256 the result is 0.
@@ -47,6 +45,7 @@ floor(arg2 / 2^arg1)
 ```
 
 Notes:
+
 - The value (`arg2`) is interpreted as an unsigned number.
 - The shift amount (`arg1`) is interpreted as an unsigned number.
 - If the shift amount (`arg1`) is greater or equal 256 the result is 0.
@@ -61,6 +60,7 @@ floor(arg2 / 2^arg1)
 ```
 
 Notes:
+
 - The value (`arg2`) is interpreted as a signed number.
 - The shift amount (`arg1`) is interpreted as an unsigned number.
 - If the shift amount (`arg1`) is greater or equal 256 the result is 0 if `arg2` is non-negative or -1 if `arg2` is negative.
@@ -70,7 +70,7 @@ The cost of the shift instructions is set at `verylow` tier (3 gas).
 
 ## Rationale
 
-Instruction operands were chosen to fit the more natural use case of shifting a value already on the stack. This means the operand order is swapped compared to most arithmetic insturctions.
+Instruction operands were chosen to fit the more natural use case of shifting a value already on the stack. This means the operand order is swapped compared to most arithmetic instructions.
 
 ## Backwards Compatibility
 
@@ -87,69 +87,79 @@ The newly introduced instructions have no effect on bytecode created in the past
    ---
    0x0000000000000000000000000000000000000000000000000000000000000001
    ```
+
 2. ```
    PUSH 0x0000000000000000000000000000000000000000000000000000000000000001
    PUSH 0x01
    SHL
    ---
    0x0000000000000000000000000000000000000000000000000000000000000002
    ```
+
 3. ```
    PUSH 0x0000000000000000000000000000000000000000000000000000000000000001
    PUSH 0xff
    SHL
    ---
    0x8000000000000000000000000000000000000000000000000000000000000000
    ```
+
 4. ```
    PUSH 0x0000000000000000000000000000000000000000000000000000000000000001
    PUSH 0x0100
    SHL
    ---
    0x0000000000000000000000000000000000000000000000000000000000000000
    ```
+
 5. ```
    PUSH 0x0000000000000000000000000000000000000000000000000000000000000001
    PUSH 0x0101
    SHL
    ---
    0x0000000000000000000000000000000000000000000000000000000000000000
    ```
+
 6. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0x00
    SHL
    ---
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 7. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0x01
    SHL
    ---
    0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe
    ```
+
 8. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0xff
    SHL
    ---
    0x8000000000000000000000000000000000000000000000000000000000000000
    ```
+
 9. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0x0100
    SHL
    ---
    0x0000000000000000000000000000000000000000000000000000000000000000
    ```
+
 10. ```
     PUSH 0x0000000000000000000000000000000000000000000000000000000000000000
     PUSH 0x01
     SHL
     ---
     0x0000000000000000000000000000000000000000000000000000000000000000
     ```
+
 11. ```
     PUSH 0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
     PUSH 0x01
@@ -158,7 +168,6 @@ The newly introduced instructions have no effect on bytecode created in the past
     0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe
     ```
 
-
 ### `SHR` (logical shift right)
 
 1. ```
@@ -168,69 +177,79 @@ The newly introduced instructions have no effect on bytecode created in the past
    ---
    0x0000000000000000000000000000000000000000000000000000000000000001
    ```
+
 2. ```
    PUSH 0x0000000000000000000000000000000000000000000000000000000000000001
    PUSH 0x01
    SHR
    ---
    0x0000000000000000000000000000000000000000000000000000000000000000
    ```
+
 3. ```
    PUSH 0x8000000000000000000000000000000000000000000000000000000000000000
    PUSH 0x01
    SHR
    ---
    0x4000000000000000000000000000000000000000000000000000000000000000
    ```
+
 4. ```
    PUSH 0x8000000000000000000000000000000000000000000000000000000000000000
    PUSH 0xff
    SHR
    ---
    0x0000000000000000000000000000000000000000000000000000000000000001
    ```
+
 5. ```
    PUSH 0x8000000000000000000000000000000000000000000000000000000000000000
    PUSH 0x0100
    SHR
    ---
    0x0000000000000000000000000000000000000000000000000000000000000000
    ```
+
 6. ```
    PUSH 0x8000000000000000000000000000000000000000000000000000000000000000
    PUSH 0x0101
    SHR
    ---
    0x0000000000000000000000000000000000000000000000000000000000000000
    ```
+
 7. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0x00
    SHR
    ---
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 8. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0x01
    SHR
    ---
    0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 9. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0xff
    SHR
    ---
    0x0000000000000000000000000000000000000000000000000000000000000001
    ```
+
 10. ```
     PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
     PUSH 0x0100
     SHR
     ---
     0x0000000000000000000000000000000000000000000000000000000000000000
     ```
+
 11. ```
     PUSH 0x0000000000000000000000000000000000000000000000000000000000000000
     PUSH 0x01
@@ -248,127 +267,145 @@ The newly introduced instructions have no effect on bytecode created in the past
    ---
    0x0000000000000000000000000000000000000000000000000000000000000001
    ```
+
 2. ```
    PUSH 0x0000000000000000000000000000000000000000000000000000000000000001
    PUSH 0x01
    SAR
    ---
    0x0000000000000000000000000000000000000000000000000000000000000000
    ```
+
 3. ```
    PUSH 0x8000000000000000000000000000000000000000000000000000000000000000
    PUSH 0x01
    SAR
    ---
    0xc000000000000000000000000000000000000000000000000000000000000000
    ```
+
 4. ```
    PUSH 0x8000000000000000000000000000000000000000000000000000000000000000
    PUSH 0xff
    SAR
    ---
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 5. ```
    PUSH 0x8000000000000000000000000000000000000000000000000000000000000000
    PUSH 0x0100
    SAR
    ---
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 6. ```
    PUSH 0x8000000000000000000000000000000000000000000000000000000000000000
    PUSH 0x0101
    SAR
    ---
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 7. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0x00
    SAR
    ---
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 8. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0x01
    SAR
    ---
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 9. ```
    PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    PUSH 0xff
    SAR
    ---
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    ```
+
 10. ```
     PUSH 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
     PUSH 0x0100
     SAR
     ---
     0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
     ```
+
 11. ```
     PUSH 0x0000000000000000000000000000000000000000000000000000000000000000
     PUSH 0x01
     SAR
     ---
     0x0000000000000000000000000000000000000000000000000000000000000000
     ```
+
 12. ```
     PUSH 0x4000000000000000000000000000000000000000000000000000000000000000
     PUSH 0xfe
     SAR
     ---
     0x0000000000000000000000000000000000000000000000000000000000000001
     ```
+
 13. ```
     PUSH 0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
     PUSH 0xf8
     SAR
     ---
     0x000000000000000000000000000000000000000000000000000000000000007f
     ```
+
 14. ```
     PUSH 0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
     PUSH 0xfe
     SAR
     ---
     0x0000000000000000000000000000000000000000000000000000000000000001
     ```
+
 15. ```
     PUSH 0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
     PUSH 0xff
     SAR
     ---
     0x0000000000000000000000000000000000000000000000000000000000000000
     ```
+
 16. ```
     PUSH 0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
     PUSH 0x0100
     SAR
     ---
     0x0000000000000000000000000000000000000000000000000000000000000000
     ```
-
-
-## Implementation
+
+### Implementation
 
 Client support:
+
 - cpp-ethereum: https://github.com/ethereum/cpp-ethereum/pull/4054
 
 Compiler support:
+
 - Solidity/LLL: https://github.com/ethereum/solidity/pull/2541
 
-## Tests
+### Tests
 
 Sources:
+
 - https://github.com/ethereum/tests/tree/develop/src/GeneralStateTestsFiller/stShift
 
 Filled Tests:
+
 - https://github.com/ethereum/tests/tree/develop/GeneralStateTests/stShift
 - https://github.com/ethereum/tests/tree/develop/BlockchainTests/GeneralStateTests/stShift