Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-1046: Fix some issues #7872

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Update EIP-1046: Fix some issues #7872

merged 1 commit into from
Oct 18, 2023

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Oct 18, 2023 •
edited
Loading

  1. ERC1155TokenMetadataInterop was missing a tokenId parameter.
  2. Those metadata functions aren't always optional (specifically, in the case of ERC-721).
  3. Decimals is 18 by default -- only for ERC-20.

@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-erc labels Oct 18, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 18, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update ERC-1046: Fix some issues Update EIP-1046: Fix some issues Oct 18, 2023
@eth-bot eth-bot enabled auto-merge (squash) October 18, 2023 16:04
eth-bot
eth-bot approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ab2383a into master Oct 18, 2023
12 of 22 checks passed
@eth-bot eth-bot deleted the Pandapip1-patch-10 branch October 18, 2023 16:11
@AbdullahHasankaddour AbdullahHasankaddour mentioned this pull request Oct 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal s-final This EIP is Final t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pandapip1 @eth-bot