Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Fixed rendering of headers of ERC pages, Navbar and footer #192

Closed
wants to merge 2 commits into from

Conversation

dhanushlnaik
Copy link

Website : Fixed rendering of headers of ERC pages, Navbar and footer

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 8, 2024

File config/eip-editors.yml

Requires 3 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File .bundle

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File .bundle/config

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File Gemfile.lock

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File _config.yml

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File _includes/social.html

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File _layouts/eip.html

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File index.html

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

@eip-review-bot eip-review-bot changed the title Website : Fixed rendering of headers of ERC pages, Navbar and footer Website: Fixed rendering of headers of ERC pages, Navbar and footer Jan 8, 2024
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ERCs are loaded in a CI workflow in the EIPs repo to deploy the site eips.ethereum.org. This change won't affect that website because the jekyll code would live in ethereum/eips.

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants