Update ERC-165: Clarify misleading usage of pure attribute
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File
|
eip-review-bot
changed the title
pure attributepure attribute
|
The commit cc80b06 (as a parent of b913c3f) contains errors. |
Jean68172
approved these changes
Feb 28, 2024
14 tasks
|
As discussed on EIPIP (ethcatherders/EIPIP#336), we don't feel like the clarification justifies changing a Final ERC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example provided after the phrase still uses
viewattribute. Either the example or the description before that should change.If the example is changed, it would be ambiguous whether the ERC-165 imposes restriction on the usage of
vieworpurefor thesupportsInterfacefunction.