Add EIP-4844 transaction and receipt #398

acolytec3 · 2023-04-05T19:08:04Z

As discussed in recent 4844 implementers calls, this proposes to add optional fields for blobGasUsed and blobGasPrice to the transaction receipt object specific to 4844 blob transactions.

g11tech

looks good, should it also not be part of the encoding as noticed by @jochem-brouwer

roberto-bayardo · 2023-04-06T18:54:46Z

looks good, should it also not be part of the encoding as noticed by @jochem-brouwer

I don't think we'd want it encoded since the values can be derived from protocol rules. The field is being added more for convenience. And to that end, I wonder if the value of data_gasprice should be in there too, in order to be able to conveniently compute the gas cost component incurred by the blobs. Without this you'd have to re-implement get_data_gasprice from the spec and hope the parameters never change.

lightclient

This change seems fine, but there are other large changes to the RPC that need to be made for cancun so I am going to hold off merging this until that solidifies. We don't really have much ability on execution rpc side of things to denote fork-related info.

src/schemas/receipt.yaml

LukaszRozmej · 2023-04-07T09:54:28Z

Is this change only for RPC and not for receipts RLP in devp2p?

acolytec3 · 2023-04-07T11:28:11Z

Is this change only for RPC and not for receipts RLP in devp2p?

That was my understanding from the discussion on the last implementers call.

roberto-bayardo · 2023-04-07T18:24:43Z

Can we add dataGasPrice too? I think without it this change isn't very helpful. Having both fields allows one to calculate total gas cost easily from the tx receipt in a way that will be forward compatible with any 4844 parameter tweaks:

(effectiveGasPrice * gasUsed) + (dataGasPrice * dataGasUsed)

macfarla

some punctuation nits

src/schemas/receipt.yaml

karalabe · 2023-07-27T11:09:14Z

We should rename these to blobGasUsed and blobGasPrice

yperbasis · 2023-07-28T11:26:36Z

We should rename these to blobGasUsed and blobGasPrice

Yes, please. See ethereum/EIPs#7354

acolytec3 · 2023-07-28T12:52:33Z

We should rename these to blobGasUsed and blobGasPrice

Done. Thanks for the reminder.

lightclient · 2023-09-05T13:58:13Z

@acolytec3 I'm co-opting this PR a bit to push through all the EIP-4844 changes together.

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

…awTransaction

lightclient

LGTM! Going to merge this into eth-cancun to push up the combined tests.

* Add dataGasUsed to receipt * Make dataGasUsed optional * Add dataGasPrice * Update src/schemas/receipt.yaml Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Update src/schemas/receipt.yaml Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Update src/schemas/receipt.yaml Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * rename data gas to blob gas - eip 7354 * schemas/tx: add 4844 tx * schemas/tx: add 4844 blob fields to generic transaction * eth/submit: make note that 4844 txs must be in network form for sendRawTransaction * schemas: fix typo in 4844 tx uint ref * schemas: remove some extra spacing * schema: update required fields for blob tx repr --------- Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: lightclient <lightclient@protonmail.com>

* Add Parent Beacon Block Root to Block (#450) * Add EIP-4844 transaction and receipt (#398) * Add dataGasUsed to receipt * Make dataGasUsed optional * Add dataGasPrice * Update src/schemas/receipt.yaml Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Update src/schemas/receipt.yaml Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Update src/schemas/receipt.yaml Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * rename data gas to blob gas - eip 7354 * schemas/tx: add 4844 tx * schemas/tx: add 4844 blob fields to generic transaction * eth/submit: make note that 4844 txs must be in network form for sendRawTransaction * schemas: fix typo in 4844 tx uint ref * schemas: remove some extra spacing * schema: update required fields for blob tx repr --------- Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: lightclient <lightclient@protonmail.com> * eth: add new 4844 header fields * tests: update for cancun * tests: non-zero parent beacon block root --------- Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

g11tech approved these changes Apr 6, 2023

View reviewed changes

g11tech mentioned this pull request Apr 6, 2023

Add dataGasUsed to txReceipt and result ethereumjs/ethereumjs-monorepo#2620

Merged

lightclient reviewed Apr 6, 2023

View reviewed changes

lightclient added the F-cancun label Apr 6, 2023

lightclient reviewed Apr 6, 2023

View reviewed changes

src/schemas/receipt.yaml Outdated Show resolved Hide resolved

MarekM25 mentioned this pull request Apr 7, 2023

Add dataGasUsed to receipts for 4844 txs NethermindEth/nethermind#5546

Open

acolytec3 changed the title ~~Add dataGasUsed to receipts for 4844 txs~~ Add dataGasUsed and dataGasPrice to receipts for 4844 txs Apr 13, 2023

marioevz mentioned this pull request May 23, 2023

simulators/ethereum/engine: Engine API Cancun ethereum/hive#759

Merged

8 tasks

jflo mentioned this pull request May 23, 2023

DataGas details in receipts via RPC hyperledger/besu#5489

Closed

g11tech mentioned this pull request May 25, 2023

Execution Layer Meeting 162 ethereum/pm#781

Closed

onbjerg mentioned this pull request May 29, 2023

Tracking: EIP-4844 paradigmxyz/reth#2893

Closed

deffrian mentioned this pull request Jun 4, 2023

Blob gas info in receipts NethermindEth/nethermind#5767

Merged

12 tasks

macfarla reviewed Jun 8, 2023

View reviewed changes

src/schemas/receipt.yaml Outdated Show resolved Hide resolved

src/schemas/receipt.yaml Outdated Show resolved Hide resolved

src/schemas/receipt.yaml Outdated Show resolved Hide resolved

tersec mentioned this pull request Jun 8, 2023

4844-devnet-6 specs status-im/nimbus-eth2#5041

Closed

20 tasks

spencer-tb mentioned this pull request Jun 15, 2023

EIP-4844 Spec Change Tracker ethereum/execution-spec-tests#130

Open

henridf mentioned this pull request Jul 12, 2023

dencun-devnet-8 specs (4844-related list) status-im/nimbus-eth2#5185

Closed

6 tasks

acolytec3 changed the title ~~Add dataGasUsed and dataGasPrice to receipts for 4844 txs~~ Add blobGasUsed and blobGasPrice to receipts for 4844 txs Jul 28, 2023

yperbasis mentioned this pull request Aug 2, 2023

Execution Layer Meeting 167 ethereum/pm#836

Closed

yperbasis approved these changes Aug 13, 2023

View reviewed changes

yperbasis mentioned this pull request Aug 13, 2023

blobGasUsed in transaction receipt should be 0x hex string erigontech/erigon#8015

Closed

macfarla mentioned this pull request Aug 18, 2023

EIP-4788: Beacon Block Root hyperledger/besu#5655

Closed

tersec mentioned this pull request Sep 1, 2023

Dencun devnet-9 status-im/nimbus-eth2#5383

Closed

barnabasbusa mentioned this pull request Sep 4, 2023

Dencun Interop Testing Call #30 ethereum/pm#855

Closed

lightclient mentioned this pull request Sep 5, 2023

eth: add tx,receipt EIP4844 fields #458

Closed

lightclient force-pushed the patch-1 branch from d497e2b to 8e4ffc1 Compare September 5, 2023 13:57

lightclient changed the title ~~Add blobGasUsed and blobGasPrice to receipts for 4844 txs~~ Add EIP-4844 transaction and receipt Sep 5, 2023

lightclient force-pushed the patch-1 branch from 8e4ffc1 to e923266 Compare September 5, 2023 15:16

acolytec3 and others added 10 commits September 7, 2023 14:31

Add dataGasUsed to receipt

eb249d4

Make dataGasUsed optional

d27889d

Add dataGasPrice

74baadd

Update src/schemas/receipt.yaml

3d659f2

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Update src/schemas/receipt.yaml

7c6470c

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Update src/schemas/receipt.yaml

b84f421

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

rename data gas to blob gas - eip 7354

42bcd11

schemas/tx: add 4844 tx

a4ec599

schemas/tx: add 4844 blob fields to generic transaction

eca7487

eth/submit: make note that 4844 txs must be in network form for sendR…

b2002ee

…awTransaction

lightclient force-pushed the patch-1 branch from 3557a2c to b2002ee Compare September 7, 2023 20:36

lightclient added the A-spec Area: specification label Sep 15, 2023

jochem-brouwer mentioned this pull request Sep 19, 2023

client/vm: fix block builder london transition ethereumjs/ethereumjs-monorepo#3039

Merged

schemas: fix typo in 4844 tx uint ref

db28871

lightclient force-pushed the patch-1 branch 2 times, most recently from 8e4ffc1 to db28871 Compare October 14, 2023 02:12

schemas: remove some extra spacing

66cffd3

lightclient changed the base branch from main to eth-cancun October 14, 2023 02:19

schema: update required fields for blob tx repr

de766b3

lightclient approved these changes Oct 14, 2023

View reviewed changes

lightclient merged commit ab83ce8 into ethereum:eth-cancun Oct 14, 2023
3 checks passed

lightclient mentioned this pull request Oct 14, 2023

eth: EIP-4844 and EIP-4788 updates for cancun #477

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP-4844 transaction and receipt #398

Add EIP-4844 transaction and receipt #398

acolytec3 commented Apr 5, 2023 •

edited

Loading

g11tech left a comment •

edited

Loading

roberto-bayardo commented Apr 6, 2023 •

edited

Loading

lightclient left a comment

LukaszRozmej commented Apr 7, 2023

acolytec3 commented Apr 7, 2023

roberto-bayardo commented Apr 7, 2023

macfarla left a comment

karalabe commented Jul 27, 2023

yperbasis commented Jul 28, 2023

acolytec3 commented Jul 28, 2023

lightclient commented Sep 5, 2023 •

edited

Loading

lightclient left a comment

Add EIP-4844 transaction and receipt #398

Add EIP-4844 transaction and receipt #398

Conversation

acolytec3 commented Apr 5, 2023 • edited Loading

g11tech left a comment • edited Loading

Choose a reason for hiding this comment

roberto-bayardo commented Apr 6, 2023 • edited Loading

lightclient left a comment

Choose a reason for hiding this comment

LukaszRozmej commented Apr 7, 2023

acolytec3 commented Apr 7, 2023

roberto-bayardo commented Apr 7, 2023

macfarla left a comment

Choose a reason for hiding this comment

karalabe commented Jul 27, 2023

yperbasis commented Jul 28, 2023

acolytec3 commented Jul 28, 2023

lightclient commented Sep 5, 2023 • edited Loading

lightclient left a comment

Choose a reason for hiding this comment

acolytec3 commented Apr 5, 2023 •

edited

Loading

g11tech left a comment •

edited

Loading

roberto-bayardo commented Apr 6, 2023 •

edited

Loading

lightclient commented Sep 5, 2023 •

edited

Loading