Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix state test error checking #25702

Merged
merged 3 commits into from
Sep 26, 2022
Merged

tests: fix state test error checking #25702

merged 3 commits into from
Sep 26, 2022

Commits on Sep 6, 2022

  1. tests: add error check for false negatives 

    Some tests define an 'expectException' error
but the tests runner does not check for conditions
where this test value is filled (error expected)
but in which no error is returned by the test runner.

An example of this scenario is
GeneralStateTests/stTransactionTest/HighGasPrice.json,
which expects a 'TR_NoFunds' error, but
the test runner does not return any error.

Date: 2022-09-06 15:03:11-07:00
Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2d5d663 View commit details
    Browse the repository at this point in the history

  2. tests: raise error returned by core.ApplyMessage 

    This allows the test runner to compare expected vs
yielded errors.

Date: 2022-09-06 15:05:11-07:00
Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a3ed8fa View commit details
    Browse the repository at this point in the history

  3. tests: method checks error expectations for state tests 

    Date: 2022-09-06 15:34:32-07:00
Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f8cbab5 View commit details
    Browse the repository at this point in the history