Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, eth/downloader, params: validate blob tx bodies #27392

Merged
merged 1 commit into from
May 31, 2023

Conversation

karalabe
Copy link
Member

This PR adds the blob hash validations for the blob transactions. An open question however is whether setting to to field to nil should be rejected (as in the spec and PR currently), or whether the data type itself should be changed to never be able to be nil. I vote for the latter, but that needs a spec change.

@karalabe karalabe added this to the 1.12.1 milestone May 31, 2023
@karalabe karalabe mentioned this pull request May 31, 2023
26 tasks
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 495692c into ethereum:master May 31, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants