Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2259 #2271

Closed
wants to merge 4 commits into from
Closed

Fixes #2259 #2271

wants to merge 4 commits into from

Conversation

broper2
Copy link
Contributor

@broper2 broper2 commented Dec 19, 2021

What was wrong?

Dependency on eth_maxPriorityFeePerGas

Related to Issue #2259

How was it fixed?

See analysis on issue #2259, eth_maxPriorityFeePerGas == (gas_price - latest block base fee)

Tests expected results were updated to new logic implemented, and verified they make sense against test provider api
endpoint defaults. When connected to ethereum network, this will be a no-impact change to an api supporting eth_maxPriorityFeePerGas

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@broper2
Copy link
Contributor Author

broper2 commented Dec 19, 2021

Checking some of these tests....

@broper2 broper2 closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant