-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm/tests: add support for test networks with activated EIPs #1617
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There are a few leftover console.logs |
Don't know why I did not notice that when linting 🤔 Removed them. |
Thanks! I believe we have the no-console rule overridden to be ignored in tester.ts since we log some other important output. You can see that in packages/vm/.eslintrc.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one change to use common.custom
instead of the deprecated common.forCustomChain
but looks great otherwise! I tested with a couple of different hardfork combinations and it parsed them all correctly (and threw an error if trying to set an unsupported hardfork - as expected).
Can we also add 1-2 lines on how to use this in the developer README somewhere here? Also ok of course to somewhat restructure along if the current structure of the section is generally not so optimal or something. |
Can this be updated at some point? |
I will update this before the end of this month. |
Updated docs, thanks for the reviews 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds support for
ethereum/tests
forks where there are added EIPs; these are usually experimental and it is not clear if they will ever be in an actual fork, but they have tests anyways.To test;
Results in 12 passing tests, so looks like we pass the (draft) tests for EIP3855 as well 😄