Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: utility module flatting and limiting #395

Merged
merged 1 commit into from
Sep 1, 2021
Merged

refactor!: utility module flatting and limiting #395

merged 1 commit into from
Sep 1, 2021

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Aug 18, 2021

Closes #385

@AuHau AuHau requested review from agazso and a team August 18, 2021 06:04
@AuHau AuHau requested a review from nugaon as a code owner August 18, 2021 06:04
vojtechsimetka
vojtechsimetka approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@vojtechsimetka vojtechsimetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

Base automatically changed from refactor/ky to master August 30, 2021 11:55
nugaon
nugaon approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@nugaon nugaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this merge we have to think about adding every new utility function to this list.

it can be merged from my side, but anyway, we will have swarm-js-utils soon : )

@AuHau AuHau merged commit ee68ed2 into master Sep 1, 2021
@AuHau AuHau deleted the refactor/utils branch September 1, 2021 05:50
@bee-worker bee-worker mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agazso agazso agazso approved these changes

@vojtechsimetka vojtechsimetka vojtechsimetka approved these changes

@nugaon nugaon nugaon approved these changes

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Over-exposed" utility functions
4 participants
@AuHau @agazso @vojtechsimetka @nugaon