Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some create-react-app build fixes #1

Closed
wants to merge 74 commits into from

Conversation

willsmythe
Copy link

  1. Set CI to ensure the correct flow in the build script
  2. Set VSTS_OVERWRITE_TEMP to avoid test problems related to weirdness with "temp" path math (especially on Windows where the short and long file paths are different)
  3. Increased the number of times Verdaccio will try to get a package from npmjs.org. This seems to fix some of the "can't find package" problems, but not all. I had to enable Verdaccio "file" logging to actually understand that Verdaccio was getting timeout errors connecting to npmjs.org. I briefly explored setting up an Artifacts feed, but it wasn't obvious how to use/auth this registry from a pipeline (maybe the "npm authenticate" task, but I didn't have time to explore)
  4. LF checkout (mainly for Windows) to avoid test failures due to line endings

yangshun and others added 30 commits February 8, 2019 22:29
 - create-react-app@2.1.5
 - react-dev-utils@7.0.3
 - react-scripts@2.1.5
Upgrade Docusaurus and enable new features
* Add forward ref to SVG component

* Write proper component for the ref test

* Add ref to jest svg transform and fix tests

* Fix SVG file location

* Use proper `ref` instead of svgRef in tests

* Add ref to svgr loader
"Collocation" insead of "Colocation".
* Revert "Revert "Speed up TypeScript projects (facebook#5903)""

This reverts commit 544a594.

* Move fork-ts-checker dep to react-dev-utils

* Convert WebpackDevServerUtils.createCompiler to take in options arg

* Update README.md for react-dev-utils
The current `analyze` script only analises the `/src` code. This change leverages new version of `source-map-explorer` that is able to analyse multiple bundles at once, including the  3rd party dependencies bundle which is in my opinion even more important to analyze.
Aftabnack and others added 27 commits March 10, 2019 13:22
…ok#6451)

* change class component to function component

* Update packages/react-scripts/template/src/App.js

Co-Authored-By: xiaoxiangmoe <xiaoxiangmoe@gmail.com>

* Update packages/react-scripts/template-typescript/src/App.tsx

Co-Authored-By: xiaoxiangmoe <xiaoxiangmoe@gmail.com>
compiler is not being reassigned, so we can use a const here
* Upgrade dependencies

* Upgrade a couple missed deps

* Run Prettier over codebase
* add command to add files to staging after eject

* update console.log message

* wrap git add in a try/catch block

* return true & update log message

* add test to check if files were staged

* Fix check for staged files
* Add note about npx caching and link to facebook#6119

It is necessary to uninstall any version that was previously installed for the typescript flag to work when using npx.

* Use proper casing for TypeScript

Co-Authored-By: TaylorBriggs <TaylorBriggs@users.noreply.github.com>
* Add browserslist support to @babel/preset-env

* Support @babel/polyfill in entry point
* Add Babel plug-in for Hooks; Add ESLint plug-in for Hooks (WIP)

* Fix transform destructuring loose config

* Add eslint-plugin-react-hooks to package.json

* Fix package.json's

* Fix eslint-plugin-react-hooks version

* Fix package.json

* Fix package.json

* Add eslint-plugin-react-hooks to script package.json

* Force array destructuring to work in loose mode only for known Hooks

* Update based on feedback from PR

* Add 'exhaustive-deps' lint rule

* Bump eslint-plugin-react-hooks to stable version

* Remove extraneous dependency from react-scripts
* Initial pass adding typescript-eslint

* Add warning to shared rule set

* Add documentation for setting up VSCode extension

* Provide tsconfig path to typescript-eslitn
* Update to jest 24

* Add notice about pnpResolver.js

* Formatting

* Fix linting

* Update to jest 24.1.0

* Update jest-pnp-resolver

* Swap create-react-app params in e2e scripts

* Add extraGlobals to supportedKeys

* Bump jest to 24.3.1

* Bump jest to 24.4.0

* Bumb jest to 24.5.0

* Update template dependencies jest to 24.5.0

* Debug failing test

* Remove jest-pnp-resolver

* Remove console.log

* Revert yarn.lock.cached
…#6662)

Sync the `babel-eslint` version between react-scripts and eslint-config-react-app
…ion (facebook#6655)

* Change app component declaration from arrow function to regular function

* Change TypeScript template back to an arrow function
`url` was duplicated in `siteConfig.js`, both were the same value, so stripping one of them.
* Add AWS Amplify deployments to the CRA Docs

* Fixed typos

* added gif

* GIF link

* Update docusaurus/docs/deployment.md

* create-react-app to Create React App

* Update docusaurus/docs/deployment.md

* Removed extra verbiage.

* Removed GIF
@willsmythe
Copy link
Author

Moved this PR over to my fork so I could rebase on the latest from facebook/create-react-app and show the changes. See: willsmythe#2

@willsmythe willsmythe closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.