Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker compose run output is missing from github actions #375

Closed
earmenda opened this issue Feb 23, 2022 · 2 comments · Fixed by #376
Closed

docker compose run output is missing from github actions #375

earmenda opened this issue Feb 23, 2022 · 2 comments · Fixed by #376
Assignees
Labels
bug Something isn't working

Comments

@earmenda
Copy link
Contributor

earmenda commented Feb 23, 2022

Bug Description

Sometime after 1/21/22 our docker compose command output stopped showing up in our github action logs. I created a PR #374 to test that we did not introduce a regression. Old code which used to output the logs no longer works like it used to. This almost confirms that there was a change outside our project which caused this.

Take a look at our Pytest output in these actions:
1/21/22 Run - https://github.com/ethyca/fides/runs/4901660513
1/24/22 Run - https://github.com/ethyca/fides/runs/4925411776

The run on the 24th is missing the test output.

Steps to Reproduce

Submit PR with any code changes. Pytest action will not show any test output.

Expected behavior

PR checks should show test output:

=============================================================================== test session starts ================================================================================
platform linux -- Python 3.8.12, pytest-6.2.2, py-1.11.0, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /fides/fidesctl, configfile: pyproject.toml, testpaths: tests
plugins: requests-mock-1.8.0, cov-2.11.1
collected 244 items / 145 deselected / 99 selected                                                                                                                                 

tests/cli/test_cli.py::test_parse PASSED                                                                                                                                     [  1%]
tests/core/test_api.py::test_generate_resource_urls_no_id PASSED                                                                                                             [  2%]
tests/core/test_api.py::test_generate_resource_urls_with_id PASSED              

Environment

Default github action container

@earmenda earmenda added the bug Something isn't working label Feb 23, 2022
@earmenda earmenda added this to the fidesctl 1.4.0 milestone Feb 23, 2022
@earmenda earmenda self-assigned this Feb 23, 2022
@earmenda
Copy link
Contributor Author

Found reports of something similar which aligns with the time that we started seeing this - virtual-environments-5022

The root cause is a docker version change from v2.2.2 to v2.2.3 which introduced this change - docker-compose-9035

I'm pretty sure that this is also what broke our docs publishing recently: #358

@earmenda
Copy link
Contributor Author

2.2.2 and previous releases tried to guess the context is a TTY, and set -T accordingly. This demonstrated to have various side effects when it comes to stdin / stdout redirection within a terminal, so we preferred to ask the user for explicit configuration when using compose in a non-tty environment.

@iamkelllly iamkelllly modified the milestone: fidesctl 1.4.0 Mar 16, 2022
ThomasLaPiana pushed a commit that referenced this issue Aug 17, 2022
* Investigate segment masking test failures.

* Remove pause - if there are future test failures we may need to investigate again.

* Restore pause.
ThomasLaPiana pushed a commit that referenced this issue Sep 26, 2022
* Investigate segment masking test failures.

* Remove pause - if there are future test failures we may need to investigate again.

* Restore pause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants