fix: make base client assumerole more expressive when decoding body

evergreen-ci · Sep 25, 2024 · db7a314 · db7a314
1 parent 21d2315
commit db7a314
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/agent/internal/client/base_client.go b/agent/internal/client/base_client.go
@@ -1027,6 +1027,9 @@ func (c *baseCommunicator) AssumeRole(ctx context.Context, td TaskData, request
 	if resp.StatusCode != http.StatusOK {
 		return nil, util.RespErrorf(resp, "trouble assuming role")
 	}
-	creds := apimodels.AssumeRoleResponse{}
-	return &creds, errors.Wrapf(utility.ReadJSON(resp.Body, &creds), "reading assume role response")
+	var creds apimodels.AssumeRoleResponse
+	if err := utility.ReadJSON(resp.Body, &creds); err != nil {
+		return nil, errors.Wrap(err, "reading assume role response")
+	}
+	return &creds, nil
 }