DEVPROD-10201: Improve mapping between GraphQL User type and APIDBUser struct #8340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minnakt
commented
Sep 24, 2024
rest/model/generated.go
Outdated
There was a problem hiding this comment.
this is legacy generated code but according to the comments manual edits are allowed? The legacy codegen tool was already removed from Evergreen a while ago DEVPROD-971
hadjri
reviewed
Sep 25, 2024
| dbUser := restModel.APIDBUserToService(toUpdate) | ||
|
|
||
| dbUser, err := toUpdate.ToService() | ||
| if err != nil { |
| restModel "github.com/evergreen-ci/evergreen/rest/model" | ||
| "github.com/evergreen-ci/utility" | ||
| ) | ||
|
|
||
| // ParsleyFilters is the resolver for the parsleyFilters field. |
There was a problem hiding this comment.
Is this removal intended? Was the removal generated?
There was a problem hiding this comment.
now that we use the complete APIDBUser as the underlying model, these get automatically resolved so we don't have to write any resolver code for them 🙂
Here's an example of this still working (running locally on this PR):
hadjri
approved these changes
Sep 25, 2024
sophstad
approved these changes
Sep 25, 2024
minnakt
changed the title
minnakt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-10201
Description
I noticed that the way in which we process a
Userin GraphQL doesn't follow the patterns we have elsewhere. This PR updates the logic aroundAPIDBUserwhich is the underlying model forUserin GraphQL.Testing
/graphqlsandbox