Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-11778: Do not log warning messages for empty Evergreen test logs #8358

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

julianedwards
Copy link
Contributor

@julianedwards julianedwards commented Oct 1, 2024

DEVPROD-11778

Description

Reduce noise in Evergreen logging warning messages.

If a log line is empty with just timestamp, the Evergreen agent should just ignore the line and move on rather than logging a warning. This is confusing for users and adds a lot of noise to the logs.

Testing

Added new test to ensure empty lines are ok.

Documentation

N/A

@ybrill
Copy link
Contributor

ybrill commented Oct 1, 2024

Could it make sense to add a test here?

@julianedwards
Copy link
Contributor Author

Could it make sense to add a test here?

Done!

@julianedwards julianedwards merged commit 3397e3f into evergreen-ci:main Oct 1, 2024
10 checks passed
@julianedwards julianedwards deleted the DEVPROD-11778 branch October 1, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants