DEVPROD-11769: Improve waterfall handling for inactive versions #8361
+138
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
force-pushed
the
DEVPROD-11769
branch
from
e23b8ff
to
f297ac8
Compare
minnakt
reviewed
Oct 3, 2024
| @@ -103,7 +103,8 @@ func GetActiveWaterfallVersions(ctx context.Context, projectId string, opts Wate | |||
|
|
|||
| // GetAllWaterfallVersions returns all of a project's versions within an inclusive range of orders. | |||
| func GetAllWaterfallVersions(ctx context.Context, projectId string, minOrder int, maxOrder int) ([]Version, error) { | |||
There was a problem hiding this comment.
I think there might be a small bug with the revision order number range, when I load the default Spruce waterfall I see 13 inactive versions at the end (which doesn't show up on the main branch). Comparing with the Project Health page, I think these commits might actually be active so they wouldn't end up being collapsed 👀
sophstad
force-pushed
the
DEVPROD-11769
branch
from
3470b38
to
953bf52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-11769
Description
Testing