implement pylint checking

Fixes: Katello#216
evgeni · Sep 5, 2017 · 159def7 · 159def7
1 parent 057704b
commit 159def7
Show file tree

Hide file tree

Showing 4 changed files with 412 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -5,7 +5,7 @@ services:
   - docker
 
 install:
-  - pip install flake8
+  - pip install flake8 pylint
 
 script:
   - make test
diff --git a/Makefile b/Makefile
@@ -2,6 +2,7 @@ TEST_TARGETS=centos\:5 centos\:6 centos\:7
 
 test: $(addprefix test-,$(TEST_TARGETS))
 	flake8 --ignore E501 ./bootstrap.py ./setup.py
+	pylint --reports=n --disable=I --ignore-imports=y ./bootstrap.py ./setup.py
 
 test-%:
 	docker run -it --volume $(CURDIR):/app --workdir=/app $* python bootstrap.py --help

diff --git a/bootstrap.py b/bootstrap.py
@@ -7,7 +7,6 @@
 Use `awk -F'# >' 'NF>1 {print $2}' ./bootstrap.py` to see the flow.
 """
 
-import yum
 import getpass
 import urllib2
 import base64
@@ -19,13 +18,14 @@
 import pwd
 import glob
 import shutil
-import rpm
-import rpmUtils.miscutils
 import tempfile
 from datetime import datetime
 from optparse import OptionParser
 from urllib import urlencode
 from ConfigParser import SafeConfigParser
+import yum
+import rpm
+import rpmUtils.miscutils
 
 
 VERSION = '1.4.1'