-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esl-utils): debounced unhandled rejection #1839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider an alternative approach:
- do not change debounce (most likely, at all). A similar issue may appear in other async decorators
- Make the
Deferred
utility improved with a lazy<instanceof Deferred>.promise
instead
The original request to make a class was related to Defered
but not a denounced.
Please also provide tests to make sure we have no problem (ideally, first of all, make a unit test cases and make sure they are correct but not successful, and then provide a fix)
Co-authored-by: Anastasiya Lesun <72765981+NastaLeo@users.noreply.github.com>
Code Climate has analyzed commit 4fb5a0a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.4% (0.1% change). View more on Code Climate. |
1f18a8a
to
6506db7
Compare
The scope of this PR is to fix the issue described in #1801, and to refactor code from a function to a class
closes #1801