[ESL Anchornav] final update #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshovchko
requested review from
ala-n,
yadamskaya,
abarmina,
Natalie-Smirnova,
fshovchko,
HenadzV,
NastaLeo and
a team
dshovchko
changed the title
ala-n
reviewed
Aug 30, 2024
| @@ -29,7 +29,7 @@ export class ESLAnchornavSticked extends ESLMixinElement { | |||
| public set sticked(value: boolean) { | |||
| if (this._sticked === value) return; | |||
| this._sticked = value; | |||
| this.$$attr('sticked', value); | |||
| this.$$cls(`${ESLAnchornavSticked.is}-active`, value); | |||
There was a problem hiding this comment.
Mb configurable attribute ?
There was a problem hiding this comment.
esl-anchornav-sticked="{activeClass: 'anchornav-sticked'}" ?
There was a problem hiding this comment.
It looks better, but it's cosmetic for now.
NastaLeo
approved these changes
Sep 2, 2024
ala-n
approved these changes
Sep 16, 2024
abarmina
approved these changes
Sep 25, 2024
fshovchko
approved these changes
Sep 26, 2024
|
🎉 This PR is included in version 5.0.0-beta.36 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2578