Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect existing solutions from being overwritten by 'download' #979

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

haguro
Copy link
Contributor

@haguro haguro commented Feb 4, 2021

Add an optional --force flag to the download command to overwrite an existing exercise directory as suggested in several issues and discussions.

Should fix exercism/exercism#5432 and probably #872 too.

Feedback or further guidance is much appreciated 👍

Add an optional `--force` flag to the download command to overwrite
an existing exercise directory.
@haguro
Copy link
Contributor Author

haguro commented Feb 5, 2021

The travis builds for Go 1.11 and 1.12 are failing due to compile errors in the testify package. Building with Go latest (and locally Go 1.15) is successful. Is there a reason for the cli to be buildable with those old Go versions?

@iHiD iHiD requested a review from ekingery February 9, 2021 13:15
@iHiD
Copy link
Member

iHiD commented Feb 9, 2021

@haguro Thanks :) I don't speak Go so this will require @ekingery taking a look :)

Copy link
Contributor

@ekingery ekingery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests look great, thanks so much, @haguro! If you are interested in additional contributions to the exercism, we have plenty of work to do on the Go track to get ready for the V3 launch. Let me know if so!

@ekingery ekingery merged commit ce8f497 into exercism:main Feb 9, 2021
@haguro
Copy link
Contributor Author

haguro commented Feb 9, 2021

Many thanks @ekingery. Yes, I would be happy to lend a hand!

@ekingery
Copy link
Contributor

Many thanks @ekingery. Yes, I would be happy to lend a hand!

Excellent! If you would like a slack invite, send me your email address (mine is my username at gmail). If you don't like Slack, I'll just add you to an issue or two once the work is ready to be distributed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exercism download will nuke your previous work for that exercise if (accidentally) run a second time
3 participants