-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mk: use as a plain repo instead of a submodule #575
Merged
sauterp
merged 14 commits into
master
from
philippsauter/sc-88913/go-mk-provide-alternative-to-submodule-approach
Feb 19, 2024
Merged
go.mk: use as a plain repo instead of a submodule #575
sauterp
merged 14 commits into
master
from
philippsauter/sc-88913/go-mk-provide-alternative-to-submodule-approach
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #88913: go.mk: provide alternative to submodule approach. |
sauterp
changed the title
go.mk: use as a plain repo instead of submodule
go.mk: use as a plain repo instead of a submodule
Feb 16, 2024
PhilippeChepy
approved these changes
Feb 19, 2024
kobajagi
approved these changes
Feb 19, 2024
sauterp
deleted the
philippsauter/sc-88913/go-mk-provide-alternative-to-submodule-approach
branch
February 19, 2024 15:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We remove the
go.mk
as a submodule and ensure that it is automatically cloned and kept up to date with make.Checklist
(For exoscale contributors)
Testing
If
go.mk
doesn't exist, it will be cloned:Once it exists, it will not be cloned anymore, but make ensures, that the same ref is checked out in
go.mk
even if it was changed before.