Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Commit

Permalink
Let users know about publishing before doing a release build
Browse files Browse the repository at this point in the history
  • Loading branch information
brentvatne committed Apr 14, 2020
1 parent e30000e commit 3eb9e7e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
12 changes: 11 additions & 1 deletion packages/expo-cli/src/commands/eject/Eject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,20 @@ export async function ejectAsync(projectRoot: string, options: EjectAsyncOptions
'expo fetch:android:keystore'
)}`
);
log.nested(
`- 🚀 ${terminalLink(
'expo-updates',
'https://github.com/expo/expo/blob/master/packages/expo-updates/README.md'
)} has been configured in your project. Before you do a release build, make sure you run ${chalk.bold(
'expo publish'
)}. ${terminalLink('Learn more.', 'https://expo.fyi/release-builds-with-expo-updates')}`
);

log.newLine();
log.nested(`☑️ ${chalk.bold('When you are ready to run your project')}`);
log.nested('To compile and run your project, execute one of the following commands:');
log.nested(
'To compile and run your project in development, execute one of the following commands:'
);
let packageManager = isUsingYarn(projectRoot) ? 'yarn' : 'npm';
log.nested(`- ${chalk.bold(packageManager === 'npm' ? 'npm run ios' : 'yarn ios')}`);
log.nested(`- ${chalk.bold(packageManager === 'npm' ? 'npm run android' : 'yarn android')}`);
Expand Down
9 changes: 9 additions & 0 deletions packages/expo-cli/src/commands/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import trimStart from 'lodash/trimStart';
import wordwrap from 'wordwrap';
import * as PackageManager from '@expo/package-manager';
import path from 'path';
import terminalLink from 'terminal-link';
import getenv from 'getenv';
import prompt from '../prompt';
import log from '../log';
Expand Down Expand Up @@ -297,6 +298,14 @@ function logProjectReady({
'android'
)} directories with their respective IDEs.`
);
log.nested(
`🚀 Please note that ${terminalLink(
'expo-updates',
'https://github.com/expo/expo/blob/master/packages/expo-updates/README.md'
)} has been configured in your project. Before you do a release build, make sure you run ${chalk.bold(
'expo publish'
)}. ${terminalLink('Learn more.', 'https://expo.fyi/release-builds-with-expo-updates')}`
);
// TODO: add equivalent of this or some command to wrap it:
// # ios
// $ open -a Xcode ./ios/{PROJECT_NAME}.xcworkspace
Expand Down

0 comments on commit 3eb9e7e

Please sign in to comment.