Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Expo export does not support uploading of sourcemaps to sentry #298

Closed
timdelange opened this issue Jan 11, 2019 · 4 comments
Closed

Expo export does not support uploading of sourcemaps to sentry #298

timdelange opened this issue Jan 11, 2019 · 4 comments
Assignees
Labels
expo export ⌘ to export static project files and merge tars

Comments

@timdelange
Copy link

Description

When using "expo export --dump-sourcemap --public-url=http://www.example.com", the resulting sourcemap isnt uploaded to sentry, despite the post-publish hook confoguration in app.json.

It is also unclear how to do this manually in a way that will allow sentry to resolve code references properly, especially/including bundles subsequently added to detached app apk/ipa's

Expected Behavior

There should be an option to have the same effect as the sentry-expo post-publish hook.

Observed Behavior

No sourcemaps are ever uploaded, manual attempts seem not to resolove properly on sentry.

Environment

I'm seeing it with expo-cli version 2.6.14, however, it has never worked since the release of "export" for expo-cli.

To Reproduce

run "expo export" in a project dir. Notice the lack of source code resolution in sentry when an error occurs.

@fson
Copy link
Contributor

fson commented Jan 14, 2019

We might need to add a separate hook for this use case, e.g. postExport, make sure it works with the sentry-expo/upload-sourcemaps script and update the docs here to mention it: https://docs.expo.io/versions/latest/guides/using-sentry

maael added a commit to maael/sentry-expo that referenced this issue Nov 6, 2019
Use case is where we're already creating releases via sentry-cli, but we want the post-publish hook (as getting sourcemaps otherwise seem to be an issue and this was made to resolve it judging from expo/expo-cli#298). Creating a new release with an existing version via sentry-cli seems to be a no-op.
@esemeniuc
Copy link

Interested in this issue as well! Local sourcemap dump would be very handy for browser debugging

@EvanBacon EvanBacon added the expo export ⌘ to export static project files and merge tars label Nov 21, 2020
@bradjones1
Copy link

Is this the necessary follow-up to expo/eas-cli#1228?

@EvanBacon
Copy link
Contributor

@bradjones1 that does seem like a fix for the original intent of the issue. Sentry + export + update works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
expo export ⌘ to export static project files and merge tars
Projects
None yet
Development

No branches or pull requests

6 participants