This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[cli] better build errors #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
reviewed
Apr 20, 2020
| ); | ||
| } | ||
| } catch (e) { | ||
| log.error('Failed to set up Push Key'); |
There was a problem hiding this comment.
is there any more context that we can provide in this error?
There was a problem hiding this comment.
The more context-specific error with the expo.fyi link is caught and rethrown (which will then print to stderr). I catch it at this point and print out Failed to set up Push Key so we know which part of the credential process we failed at. The error logging would look something like this:
Failed to set up Push Key
Additional information needed to setup credentials in non-interactive mode.
Learn more about how to resolve this: expo.fyi/credentials-non-interactive (https://expo.fyi/credentials-non-interactive).
| ); | ||
| } | ||
| } catch (e) { | ||
| log.error('Failed to set up Provisioning Profile'); |
There was a problem hiding this comment.
similar to above, is there any more context we can provide here? maybe a expo.fyi link that explains why this can happen, for example
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on weekend slack chat https://expo-developers.slack.com/archives/C04Q3JTSV/p1587257406295000?thread_ts=1586737385.022700&cid=C04Q3JTSV
why
context specific failures: before
context specific failures: after