This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] Improve readability of asyncActionProjectDir #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove auth check option - Use object for options
EvanBacon
commented
Apr 24, 2020
| @@ -117,9 +123,7 @@ export default function(program: Command) { | |||
| ...options, | |||
| dev: typeof options.dev === 'undefined' ? false : options.dev, | |||
| }); | |||
| }, | |||
| /* skipProjectValidation: */ false, | |||
There was a problem hiding this comment.
Im purposefully skipping this check now as it doesn't need to happen.
brentvatne
reviewed
Apr 26, 2020
brentvatne
approved these changes
Apr 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #1989 +/- ##
==========================================
+ Coverage 44.52% 44.90% +0.39%
==========================================
Files 99 103 +4
Lines 3956 4283 +327
Branches 976 1036 +60
==========================================
+ Hits 1761 1923 +162
- Misses 1513 1635 +122
- Partials 682 725 +43 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncActionProjectDiraccepts three parameters, we've been adding comment blocks to tell what those parameters do. This is bad practice.