Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo-cli][xdl] Reduce warning messages when logged out. [closes:#1024] #2053

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

jkhales
Copy link
Contributor

@jkhales jkhales commented Apr 30, 2020

why

#1024

how

Paired with @fson.
Created a new callback function to remove the double call to the server.
Set the silent option to quiet the redundant error message.

test

Log in to cli, then log out of all other session with web ui.
EXPO_STAGING=1 expod ph
And check the error message.

@jkhales jkhales requested a review from fson April 30, 2020 14:22
Copy link
Contributor

@fson fson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jkhales jkhales merged commit 495efd6 into master Apr 30, 2020
@jkhales jkhales deleted the @jkhales/fix-warnings branch April 30, 2020 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants