This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[config] automate android icon #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm for some reason this call is causing those |
cruzach
force-pushed
the
@cruzach/android-icon
branch
from
b6ca245
to
38aa2fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
+ Coverage 36.19% 44.90% +8.71%
==========================================
Files 153 122 -31
Lines 7047 5010 -2037
Branches 1640 1193 -447
==========================================
- Hits 2550 2249 -301
+ Misses 3279 1943 -1336
+ Partials 1218 818 -400 |
dsokal
reviewed
Jul 2, 2020
There was a problem hiding this comment.
- Looking good - except for a few missing
awaits - I don't have much context about why we need this. (I've read the PR description and the linked issue.)
- Because of that, I think I'm going to resign from approving/disapproving this PR. Maybe @brentvatne or @bbarthec could take a look at this?
bbarthec
approved these changes
Jul 2, 2020
bbarthec
suggested changes
Jul 2, 2020
Co-authored-by: Dominik Sokal <dominik.sokal@swmansion.com> Co-authored-by: Bartłomiej Bukowski <bartlomiej.bukowski@swmansion.com>
cruzach
force-pushed
the
@cruzach/android-icon
branch
from
5b88868
to
eff1748
Compare
cruzach
commented
Aug 27, 2020
packages/image-utils/src/Image.ts
Outdated
| @@ -35,6 +35,9 @@ async function resizeAsync(imageOptions: ImageOptions): Promise<Buffer> { | |||
| if (imageOptions.removeTransparency) { | |||
| jimp.colorType(2); | |||
| } | |||
| if (imageOptions.circle) { | |||
| jimp.circle(); | |||
There was a problem hiding this comment.
would like to do something similar here to how we're doing this same operation with sharp, that way this could be a setting to round the corners instead of just cut out a circle, but was running into some mimeType issues trying to create a Sharp image. but can look into that soon
There was a problem hiding this comment.
perhaps a borderRadius property would scale better
There was a problem hiding this comment.
changed it to borderRadius: number. Right now if using Jimp any number will just make the image a circle though
EvanBacon
reviewed
Aug 28, 2020
EvanBacon
reviewed
Sep 3, 2020
EvanBacon
added
expo apply
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This would automate setting the android icon and adaptive icons (Android 8+) on eject, and would enable developers to change their app icons much more easily when using the bare workflow. Plus, we could use the same code when building shell apps.
Testing
Run
yarn test. CodeCov report should go up even more if we replace the current android icons code with calls toAndroidConfig.setIconAsync😉Additional info
This should replace the current android icons code, and would fix expo/expo#7374 (if we remove the old AndroidIcons code and replace with a call to
Config.setIconAsync)