This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
remove all usages of credentials api from xdl #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsokal
approved these changes
Aug 5, 2020
| log(`Retrieving iOS credentials for ${credentialMetadata.experienceName}`); | ||
| const bundleIdentifier = ctx.manifest?.ios?.bundleIdentifier; | ||
| if (!bundleIdentifier) { | ||
| throw new Error(noBundleIdMessage); |
There was a problem hiding this comment.
Suggested change
| throw new Error(noBundleIdMessage); | |
| throw new Error(`Your project must have a \`bundleIdentifier\` set in the Expo config (app.json or app.config.js).\nSee https://expo.fyi/bundle-identifier`); |
| const { | ||
| args: { remotePackageName }, | ||
| } = await Exp.getPublishInfoAsync(projectDir); | ||
| const noBundleIdMessage = `Your project must have a \`bundleIdentifier\` set in the Expo config (app.json or app.config.js).\nSee https://expo.fyi/bundle-identifier`; |
There was a problem hiding this comment.
Suggested change
| const noBundleIdMessage = `Your project must have a \`bundleIdentifier\` set in the Expo config (app.json or app.config.js).\nSee https://expo.fyi/bundle-identifier`; |
| const credentialMetadata = await Credentials.getCredentialMetadataAsync(this.projectDir, 'ios'); | ||
| const credential = await Credentials.getCredentialsForPlatform(credentialMetadata); | ||
| const teamId = credential?.teamId; | ||
| async _getAppleTeamId(appleIdCredntials: AppleIdCredentials): Promise<string | undefined> { |
There was a problem hiding this comment.
Suggested change
| async _getAppleTeamId(appleIdCredntials: AppleIdCredentials): Promise<string | undefined> { | |
| async _getAppleTeamId(appleIdCredentials: AppleIdCredentials): Promise<string | undefined> { |
| if (teamId) { | ||
| return teamId; | ||
| } else { | ||
| const { team } = await authenticate(appleIdCrentials); | ||
| const { team } = await authenticate(appleIdCredntials); |
There was a problem hiding this comment.
Suggested change
| const { team } = await authenticate(appleIdCredntials); | |
| const { team } = await authenticate(appleIdCredentials); |
wkozyra95
force-pushed
the
@wkozyra95/remove-credentials-logic-from-xdl
branch
from
7f9bc14
to
d479f62
Compare
wkozyra95
force-pushed
the
@wkozyra95/remove-credentials-logic-from-xdl
branch
from
d479f62
to
5e9bb51
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
upload:iosto usepackages/expo-cli/src/credentials/api/IosApi.tsfetch:ios:certsto usepackages/expo-cli/src/credentials/api/IosApi.tspush:android:*to usepackages/expo-cli/src/credentials/api/AndroidApi.ts(it was already using apiv2, but I think it's cleaner for all the code to use that wrapper)Test plan
expo fetch:ios:certswith and without credentialsexpo push:android:*cmdsupload:ioscommand