This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] add --skip-credentials-check option #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
suggested changes
Aug 10, 2020
satya164
force-pushed
the
@satya164/skip-credentials
branch
2 times, most recently
from
32aa754
to
48c1198
Compare
dsokal
reviewed
Aug 26, 2020
packages/expo-cli/src/credentials/provider/iOSCredentialsProvider.ts
Outdated
Show resolved
Hide resolved
wkozyra95
approved these changes
Aug 26, 2020
packages/expo-cli/src/credentials/provider/AndroidCredentialsProvider.ts
Show resolved
Hide resolved
packages/expo-cli/src/credentials/provider/iOSCredentialsProvider.ts
Outdated
Show resolved
Hide resolved
packages/expo-cli/src/credentials/provider/iOSCredentialsProvider.ts
Outdated
Show resolved
Hide resolved
satya164
force-pushed
the
@satya164/skip-credentials
branch
from
48c1198
to
37fb759
Compare
satya164
force-pushed
the
@satya164/skip-credentials
branch
from
37fb759
to
e50ac5b
Compare
wkozyra95
reviewed
Aug 26, 2020
packages/expo-cli/src/credentials/provider/iOSCredentialsProvider.ts
Outdated
Show resolved
Hide resolved
satya164
force-pushed
the
@satya164/skip-credentials
branch
from
e50ac5b
to
eb9a8e7
Compare
satya164
force-pushed
the
@satya164/skip-credentials
branch
from
eb9a8e7
to
a4c0355
Compare
wkozyra95
approved these changes
Aug 26, 2020
packages/expo-cli/src/credentials/provider/AndroidCredentialsProvider.ts
Outdated
Show resolved
Hide resolved
packages/expo-cli/src/credentials/provider/AndroidCredentialsProvider.ts
Outdated
Show resolved
Hide resolved
packages/expo-cli/src/credentials/provider/AndroidCredentialsProvider.ts
Outdated
Show resolved
Hide resolved
satya164
force-pushed
the
@satya164/skip-credentials
branch
from
a4c0355
to
0badc58
Compare
wkozyra95
approved these changes
Aug 27, 2020
dsokal
approved these changes
Aug 27, 2020
|
Looks good, please update the changelog! :) |
satya164
force-pushed
the
@satya164/skip-credentials
branch
from
0badc58
to
d2bde41
Compare
We want people to be able to skip checking for remote credentials.
satya164
force-pushed
the
@satya164/skip-credentials
branch
from
d2bde41
to
e8b3d7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want people to be able to skip checking for remote credentials.