Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[apply] Fix iOS name changing #2497

Merged
merged 1 commit into from
Aug 25, 2020
Merged

[apply] Fix iOS name changing #2497

merged 1 commit into from
Aug 25, 2020

Conversation

EvanBacon
Copy link
Contributor

Cannot run apply after changing the name of the project:

  1. Change name in app.json
  2. expo apply
  3. Fails because it looks for ios/NewName/* when the folders haven't been renamed.

How

  • glob for the AppDelegate first, if that fails then use the config name for the iOS named folder.

@EvanBacon EvanBacon added the bug Something isn't working label Aug 25, 2020
@EvanBacon EvanBacon self-assigned this Aug 25, 2020
brentvatne
brentvatne approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@EvanBacon EvanBacon merged commit 6edede3 into master Aug 25, 2020
@EvanBacon EvanBacon deleted the @evanbacon/apply/fix-name-changing branch August 25, 2020 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brentvatne brentvatne brentvatne approved these changes

Assignees

@EvanBacon EvanBacon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanBacon @brentvatne