This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[apply] Fix android schemes being added incorrectly #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android schemes were being added incorrectly each time apply was being run, this caused the manifest to get bigger on every run of
expo apply. I fixed this by using the same logic asuri-scheme. We now remove all of the schemes, then add them all back each time, we also append the object correctly so it doesn't get duplicated.I also added an extra warning (in the same place we throw in uri-scheme) which warns the user that their manifest is not properly configured, this warning also links to an fyi for how to fix the issue.
Test Plan